lkml.org 
[lkml]   [2007]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Wipe out traditional opt from x86_64 Makefile
Glauber de Oliveira Costa wrote:
> Among other things, using -traditional as a gcc option stops us from
> using macro token pasting, which is a feature we heavily rely on.
>
> There was still a use of -traditional in arch/x86/kernel/Makefile_64,
> which this patch removes.
>
> I don't see any problems building kernels in my x86_64 box without
> -traditional.
>
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> ---
> arch/x86/kernel/Makefile_64 | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/Makefile_64 b/arch/x86/kernel/Makefile_64
> index 82da906..03a01f6 100644
> --- a/arch/x86/kernel/Makefile_64
> +++ b/arch/x86/kernel/Makefile_64
> @@ -3,7 +3,6 @@
> #
>
> extra-y := head_64.o head64.o init_task.o vmlinux.lds
> -#EXTRA_AFLAGS := -traditional
> obj-y := process_64.o signal_64.o entry_64.o traps_64.o irq_64.o \
> ptrace_64.o time_64.o ioport_64.o ldt_64.o setup_64.o i8259_64.o sys_x86_64.o \
> x8664_ksyms_64.o i387_64.o syscall_64.o vsyscall_64.o \

At least *at one point*, ld scripts were whitespace-sensitive in a way
that called for using -traditional. Doesn't mean that anything else
needs it, though.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-25 19:25    [W:0.046 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site