Messages in this thread | | | Date | Thu, 25 Oct 2007 12:55:22 +0200 | From | Sam Ravnborg <> | Subject | Re: [RFC - GIT pull] first step to get rid of x86_64 and i386 dirs |
| |
On Thu, Oct 25, 2007 at 12:18:31PM +0200, Ingo Molnar wrote: > > * Sam Ravnborg <sam@ravnborg.org> wrote: > > > Hi Ingo. > > > > This is first step in getting rid of the two directories. I had to do > > some very minor modifications in common files to let it work out - but > > nothing really hackish. > > > > If you & Thomas + hpa are OK with the changes they can be pulled from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/sam/x86.git > > > > As this is mostly renames I have attached a git -M diff only. > > wow, cool stuff! > > > The remaining stuff is Kconfig files. > > > > Before looking into these I am hoping someone could step in and make > > the two Kconfig.debug files 100% equal - because then I can fix the > > kconfig stuff and finally kill the two directories. > > How about mechanically unifying them by adding: > > depends on X86_32 > > and: > > depends on X86_64 > > lines? Can you see any problem with such an approach? Not really. But when we touch Kconfig.debug we should check up on that it reflect reality. I would be suprised if we do not miss an option or two. I am tempted to just go forward with the version Randy made where he merged the two. If I get time I will look at it tonight and send out a series of patches for review.
We have to get rid of the directories - just consider the poor victim that has her/his code reviewed by hch after he have had his nightmare ;-)
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |