Messages in this thread | | | Date | Mon, 22 Oct 2007 08:00:09 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [RFC/PATCH 2/3] rt: PI-workqueue support |
| |
--
On Mon, 22 Oct 2007, Peter Zijlstra wrote: 5B> > Index: linux-2.6/kernel/workqueue.c > =================================================================== > --- linux-2.6.orig/kernel/workqueue.c > +++ linux-2.6/kernel/workqueue.c > @@ -44,7 +44,7 @@ struct cpu_workqueue_struct { > > spinlock_t lock; > > - struct list_head worklist; > + struct plist_head worklist; > wait_queue_head_t more_work; > struct work_struct *current_work; > > @@ -127,16 +127,19 @@ struct cpu_workqueue_struct *get_wq_data > static void insert_work(struct cpu_workqueue_struct *cwq, > struct work_struct *work, int tail) > { > + int prio = current->normal_prio; > +
I'm curious to why you use normal_prio here? If the task has been boosted by some other PI method, and this task is about to sleep, why not use the actualy current->prio?
-- Steve
> set_wq_data(work, cwq); > /* > * Ensure that we get the right work->data if we see the > * result of list_add() below, see try_to_grab_pending(). > */ > smp_wmb(); > - if (tail) > - list_add_tail(&work->entry, &cwq->worklist); > - else > - list_add(&work->entry, &cwq->worklist); > + plist_node_init(&work->entry, prio); > + plist_add(&work->entry, &cwq->worklist); > + > + if (prio < cwq->thread->prio) > + task_setprio(cwq->thread, prio); > wake_up(&cwq->more_work); > } > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |