Messages in this thread | | | Date | Wed, 17 Oct 2007 09:40:52 +0200 (CEST) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH] missing include in mmc |
| |
On Tue, 16 Oct 2007, David Brownell wrote: > > > > AFAICS, fallout from repacing include of blkdev.h with include of bio.h. > > > > > > Out of curiousity, which architecture(s) need this? > > > > Umm... IIRC, m32r had been the first build to step into that, at which point > > the missing include had been added; the rest had reached that point later, so > > I'm not sure which ones would trigger the same crap. Not hard to test, > > though... > > > > Aha. m68k as well.
Yesterday I saw a similar issue with drivers/md/dm-mpath-rdac.c, but it disappeared during the night, and I didn't see an obvious change that fixed it...
> Every time I seee a case where architectures don't act the same > with respect to #includes, I count it as an unpleasant surprise. > Not one that's very easy to avoid, unfortunately, but I think it's > been happening less often lately.
Simple rule of thumb: he who uses fields of struct xxx should include the header file that defines struct xxx...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |