Messages in this thread Patch in this message | | | Date | Wed, 17 Oct 2007 13:20:18 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 0/3] vmcoreinfo support for dump filtering |
| |
On Wed, 17 Oct 2007 10:19:18 -0700 "Tony Luck" <tony.luck@intel.com> wrote:
> > This patch set frees the restriction that makedumpfile users should > > install a vmlinux file (including the debugging information) into > > each system. > > This patch went from Andrew to Linus last night, and looks at first > glance to be the reason why the ia64 build is broken this morning > when using the arch/ia64/configs/tiger_defconfig configuration. > > Here are the error messages: > arch/ia64/kernel/machine_kexec.c: In function `arch_crash_save_vmcoreinfo': > arch/ia64/kernel/machine_kexec.c:131: error: `pgdat_list' undeclared > (first use in this function) > arch/ia64/kernel/machine_kexec.c:131: error: (Each undeclared > identifier is reported only once > arch/ia64/kernel/machine_kexec.c:131: error: for each function it appears in.) > arch/ia64/kernel/machine_kexec.c:134: error: `node_memblk' undeclared > (first use in this function) > arch/ia64/kernel/machine_kexec.c:135: error: `NR_NODE_MEMBLKS' > undeclared (first use in this function) > arch/ia64/kernel/machine_kexec.c:136: error: invalid application of > `sizeof' to incomplete type `node_memblk_s' > arch/ia64/kernel/machine_kexec.c:137: error: dereferencing pointer to > incomplete type > arch/ia64/kernel/machine_kexec.c:138: error: dereferencing pointer to > incomplete type > make[1]: *** [arch/ia64/kernel/machine_kexec.o] Error 1 >
This?
--- a/arch/ia64/kernel/machine_kexec.c~ia64-fix-non-numa-build +++ a/arch/ia64/kernel/machine_kexec.c @@ -17,6 +17,8 @@ #include <linux/efi.h> #include <linux/numa.h> #include <linux/mmzone.h> + +#include <asm/numa.h> #include <asm/mmu_context.h> #include <asm/setup.h> #include <asm/delay.h> @@ -127,7 +129,7 @@ void machine_kexec(struct kimage *image) void arch_crash_save_vmcoreinfo(void) { -#ifdef CONFIG_ARCH_DISCONTIGMEM_ENABLE +#if defined(CONFIG_ARCH_DISCONTIGMEM_ENABLE) && defined(CONFIG_NUMA) VMCOREINFO_SYMBOL(pgdat_list); VMCOREINFO_LENGTH(pgdat_list, MAX_NUMNODES); _ (the asm/numa.h include isn't needed by this patch, but strictly should be there, as this file refers to things which are defined in asm/numa.h)
(it's weird that linux/numa.h doesn't include asm/numa.h)
(please tell me if you want me to send this to Linus) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |