Messages in this thread | | | Date | Wed, 17 Oct 2007 23:08:06 +0800 | From | Yi Yang <> | Subject | Re: [PATCH 2.6.23] SysRq: print hotkey info while pressing undef key |
| |
Andreas Schwab 写道: > Yi Yang <yang.y.yi@gmail.com> writes: > > >> For SysRq, we just can get hot key list from Documentation/sysrq.txt >> , but in the most of cases, the user can't access it by hand on >> using SysRq to debug, so it is better for SysRq to provide an online >> help for the users. >> >> SysRq has already provided a similiar help before this patch, but it >> is not so definite that the user doesn't know what happened and how >> to do on pressing an undefined hot key. >> >> In addition, that funtion has a big loop with another big loop >> embedded which is very inefficient, it is intended to skip some hot >> key help info for such a function as "Changing Loglevel", just print >> a help info for this, that is very unnecessary. In fact, the key '0' >> - '8' have different results the user should know. >> >> This patch add this online help function, it'll print thw whole hot >> key list and corresponding function descriptions, it can print the new >> defined hot key without any changed needed. >> >> The output is the below on pressing an undefined hot key: >> >> SysRq : <6>this hot key isn't defined. >> > ^^^ > > This is misplaced. >
printk(KERN_INFO "SysRq : \n") can fix it.
> >> @@ -410,7 +420,7 @@ void __handle_sysrq(int key, struct tty_ >> spin_lock_irqsave(&sysrq_key_table_lock, flags); >> orig_log_level = console_loglevel; >> console_loglevel = 7; >> - printk(KERN_INFO "SysRq : "); >> + printk(KERN_INFO "\nSysRq : "); >> > > It does not make any sense to put the printk level just before the > newline, since the newline resets it to the default level. > Thank you, I'll remove \n. > Andreas. > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |