lkml.org 
[lkml]   [2007]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] hptiop: avoid buffer overflow when returning sense data
    Date

    avoid buffer overflow when returning sense data.

    Signed-off-by: HighPoint Linux Team <linux@highpoint-tech.com>
    ---

    diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
    index 8b384fa..d32a4a9 100644
    --- a/drivers/scsi/hptiop.c
    +++ b/drivers/scsi/hptiop.c
    @@ -375,8 +375,9 @@ static void hptiop_host_request_callback
    scp->result = SAM_STAT_CHECK_CONDITION;
    memset(&scp->sense_buffer,
    0, sizeof(scp->sense_buffer));
    - memcpy(&scp->sense_buffer,
    - &req->sg_list, le32_to_cpu(req->dataxfer_length));
    + memcpy(&scp->sense_buffer, &req->sg_list,
    + min(sizeof(scp->sense_buffer),
    + le32_to_cpu(req->dataxfer_length)));
    break;

    default:
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-15 08:43    [W:5.133 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site