Messages in this thread | | | Date | Thu, 11 Oct 2007 14:46:13 -0700 (PDT) | Subject | Re: [PATCH net-2.6.24] remove bogus qeth type check | From | David Miller <> |
| |
From: Stephen Hemminger <shemminger@linux-foundation.org> Date: Thu, 11 Oct 2007 13:24:58 -0700
[ SOrry, I just noticed this was different... ]
> Not sure why this crept in with hard-header-ops change. > Just kill it. Need to start doing cross-compiles for s390... > > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> > > --- a/drivers/s390/net/qeth_main.c 2007-10-10 08:26:48.000000000 -0700 > +++ b/drivers/s390/net/qeth_main.c 2007-10-11 13:21:17.000000000 -0700 > @@ -6581,9 +6581,6 @@ qeth_hard_header_parse(const struct sk_b > const struct qeth_card *card; > const struct ethhdr *eth; > > - if (dev->type != ARPHRD_IEEE802_TR) > - return 0; > - > card = qeth_get_card_from_dev(skb->dev); > if (card->options.layer2) > goto haveheader;
I think you copied the check from another part of the driver. Perhaps you should double check before we kill this outright. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |