Messages in this thread | | | Subject | Re: [PATCH] FAT: Fix printk format strings. | From | OGAWA Hirofumi <> | Date | Fri, 12 Oct 2007 02:28:52 +0900 |
| |
Bodo Eggert <7eggert@gmx.de> writes:
> Vegard Nossum <vegard.nossum@gmail.com> wrote: > >> This makes sure printk format strings contain no more than a single >> line. > >> printk(KERN_WARNING >> - "FAT: Did not find valid FSINFO signature.\n" >> + "FAT: Did not find valid FSINFO signature.\n"); >> + printk(KERN_WARNING >> " Found signature1 0x%08x signature2 0x%08x" >> " (sector = %lu)\n", > > What about something like > "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x; expected 0x%08x, 0x%08\n" ? > or > "Fat32: Invalid FSINFO signatures 0x%08x, 0x%08x\n" ?
Looks good to me. I'll modify a patch, and apply it.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |