Messages in this thread Patch in this message | | | Date | Thu, 11 Oct 2007 06:57:42 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: idio{,ma}tic typos (was Re: + fix-vm_can_nonlinear-check-in-sys_remap_file_pages.patch added to -mm tree) |
| |
--- Pierre Ossman <drzeus@drzeus.cx> wrote:
> On Wed, 10 Oct 2007 14:45:40 +0400 > Alexey Dobriyan <adobriyan@sw.ru> wrote: > > > ["if (!x & y)" patch from yanzheng@] > > ["if (!x & y)" patch from adobriyan@] > > ["if (!x & y)" patches from viro@] > > > > While we're at it, below is somewhat ugly sparse patch for detecting > > "&& 0x" typos. > > > > The maintainer for tifm is Alex Dubov, so cc:ing him. > > > drivers/mmc/host/tifm_sd.c:183:9: warning: dubious && 0x > > > > if ((r_data->flags & MMC_DATA_WRITE) > > && DATA_CARRY) > > writel(host->bounce_buf_data[0], > > host->dev->addr > > + SOCK_MMCSD_DATA); > > > > given that DATA_CARRY is always used together with > > ->cmd_flags, this place is asking for obvious fixlet: > > > > > > [PATCH] tifm_sd.c: fix DATA_CARRY check > > > > Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru> > > --- > > > > drivers/mmc/host/tifm_sd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/drivers/mmc/host/tifm_sd.c > > +++ b/drivers/mmc/host/tifm_sd.c > > @@ -180,7 +180,7 @@ static void tifm_sd_transfer_data(struct tifm_sd > > *host) host->sg_pos++; > > if (host->sg_pos == host->sg_len) { > > if ((r_data->flags & MMC_DATA_WRITE) > > - && DATA_CARRY) > > + && (host->cmd_flags & > > DATA_CARRY)) writel(host->bounce_buf_data[0], > > host->dev->addr > > + SOCK_MMCSD_DATA); > > > > > > > > Rgds > Pierre >
Oops. I wonder why this was never triggered (some users are having problems with dma, so they use PIO rather extensively). The patch is probably correct, but I can't do any testing because I'm currently on vacation.
____________________________________________________________________________________ Shape Yahoo! in your own image. Join our Network Research Panel today! http://surveylink.yahoo.com/gmrs/yahoo_panel_invite.asp?a=7
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |