Messages in this thread | | | From | Pavel Pisa <> | Subject | Re: [PATCH 2.6.19] mmc: Fix handling of response types in imxmmc and tifm drivers | Date | Sun, 7 Jan 2007 18:34:22 +0100 |
| |
Hello Philip,
On Thursday 04 January 2007 16:04, Philip Langdale wrote: > This change depends on my SDHC patch and fixes a bug that was revealed > during the development of that patch. The R6 response type should be > identical to R1 (and R7) but was incorrectly defined differently. Fixing > the R6 definition breaks assumptions in these two drivers that response > type flags are unique. Pierre and Alex both believe that treating R6 and R7 > as R1 will be sufficient. ie: The controllers do not care about the > differences between them. Due to lack of hardware, I have done no testing.
I have tested your patch. Kernel builds. I have not found much time for testing. But I would not like to block changes and I am going for next week to project meeting in Spain, so there is my reply.
I have 2.6.19 + realtime-patches rt14 on the hand. I have been able to mount and use some cards, but it I have observed some problems probably related to timing when I have tried to change CPU frequency.
I need to find time to do more checking on vanilla and RT kernels when I return. I have some ideas what could be enhanced to ensure better MX1 SDHC cards recognition under RT kernels. I am not sure, what causes other seen problems, but I have observed these things on RT even without your patch.
Conclusion: I knowledge your patch and admit, that I need to find time for my homeworks.
Best wishes
Pavel Pisa
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |