Messages in this thread | | | Date | Sat, 06 Jan 2007 01:50:52 -0800 | From | Zachary Amsden <> | Subject | Re: [patch] paravirt: isolate module ops |
| |
Ingo Molnar wrote: > * Rusty Russell <rusty@rustcorp.com.au> wrote: > > >> +EXPORT_SYMBOL(clts); >> +EXPORT_SYMBOL(read_cr0); >> +EXPORT_SYMBOL(write_cr0); >> > > mark these a _GPL export. Perhaps even mark the symbol deprecated, to be > unexported once we fix raid6. >
read / write cr0 must not be GPL, since kernel_fpu_end uses them and is inline. clts I don't think matters.
>> +EXPORT_SYMBOL(wbinvd); >> +EXPORT_SYMBOL(raw_safe_halt); >> +EXPORT_SYMBOL(halt); >> +EXPORT_SYMBOL_GPL(apic_write); >> +EXPORT_SYMBOL_GPL(apic_read); >> > > these should be _GPL too. If any module uses it and breaks a user's box > we need that big licensing hint to be able to debug them ... >
Perhaps also, MSRs are too dangerous for binary modules to be messing with.
Agree on halt - but wbinvd can theoretically be used for device mapped memory consistency.
Zach - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |