lkml.org 
[lkml]   [2007]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.20-rc3] TTY_IO code cleanups
On Sat, 6 Jan 2007, Ahmed S. Darwish wrote:

> @@ -791,17 +790,15 @@ static int tty_ldisc_try(struct tty_struct *tty)
> {
> unsigned long flags;
> struct tty_ldisc *ld;
> - int ret = 0;
>
> spin_lock_irqsave(&tty_ldisc_lock, flags);
> ld = &tty->ldisc;
> - if(test_bit(TTY_LDISC, &tty->flags))
> - {
> + if(test_bit(TTY_LDISC, &tty->flags)) {
> ld->refcount++;
> - ret = 1;
> + return 1;
> }
> spin_unlock_irqrestore(&tty_ldisc_lock, flags);
> - return ret;
> + return 0;
> }
>
> /**

You leave tty_ldisk_lock locked.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-06 01:03    [W:0.035 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site