lkml.org 
[lkml]   [2007]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: NCPFS and brittle connections
Pierre Ossman wrote:
> Hi Petr,
>
> What is the status of this bug?
>
> http://bugzilla.kernel.org/show_bug.cgi?id=3328
>
> I do not see anything in the history of fs/ncpfs that seems to suggest that this, rather critical, issue has been resolved. Is anyone working on it?

Nobody is working on it (at least to my knowledge), and to me it is
feature - it always worked this way, like smbfs did back in the past -
if you send signal 9 to process using mount point, and there is some
transaction in progress, nobody can correctly finish that transaction
anymore. Fixing it would require non-trivial amount of code, and given
that NCP itself is more or less dead protocol I do not feel that it is
necessary.

If you want to fix it, feel free. Culprit is RQ_INPROGRESS handling in
ncp_abort_request - it just aborts whole connection so it does not have
to provide temporary buffers and special handling for reply - as buffers
currently specified as reply buffers are owned by caller, so after
aborting request you cannot use them anymore.
Petr Vandrovec

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-01-04 19:01    [W:0.097 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site