Messages in this thread | | | Date | Thu, 4 Jan 2007 15:52:38 +0000 | From | Christoph Hellwig <> | Subject | Re: [2.6 patch] the scheduled find_trylock_page() removal |
| |
On Thu, Jan 04, 2007 at 03:53:07PM +1100, Nick Piggin wrote: > Adrian Bunk wrote: > >This patch contains the scheduled find_trylock_page() removal. > > > >Signed-off-by: Adrian Bunk <bunk@stusta.de> > > I guess I don't have a problem with this going into -mm and making its way > upstream sometime after the next release. > > I would normally say it is OK to stay for another year because it is so > unintrusive, but I don't like the fact it doesn't give one an explicit ref > on the page -- it could be misused slightly more easily than find_lock_page > or find_get_page. > > Anyone object? Otherwise:
Just kill it. There's absolutely no point in keeping dead code around. It's bad enough we keep such things around for half a year.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |