Messages in this thread | | | Date | Wed, 03 Jan 2007 18:47:20 -0800 (PST) | Subject | Re: [PATCH 2.6.20-rc2] [BUGFIX] drivers/atm/firestream.c: Fix infinite recursion when alignment passed is 0. | From | David Miller <> |
| |
From: Amit Choudhary <amit2030@gmail.com> Date: Sat, 30 Dec 2006 18:26:03 -0800
> Description: Fix infinite recursion when alignment passed is 0 in function aligned_kmalloc(), in file drivers/atm/firestream.c. Also, a negative value for alignment does not make sense. Check for negative value too. > The function prototype is: > static void __devinit *aligned_kmalloc (int size, gfp_t flags, int alignment). > > > Signed-off-by: Amit Choudhary <amit2030@gmail.com>
There is only one call to aligned_kmalloc() and it passes in 0x10 as the alignment argument. Therefore all of this checking is completely pointless. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |