lkml.org 
[lkml]   [2007]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [xfs-masters] [PATCH} XFS: Remove placeholders for unimplemented functionality.
    On Sun, 28 Jan 2007, Eric Sandeen wrote:

    > Robert P. J. Day wrote:
    > > Remove a couple kernel config variables (FS_POSIX_CAP and
    > > FS_POSIX_MAC) that represent placeholders for unimplemented
    > > functionality.
    > >
    > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
    > >
    > > ---
    >
    > ...
    >
    > > diff --git a/fs/xfs/xfs_cap.h b/fs/xfs/xfs_cap.h
    > > index 7a0e482..cfedfd1 100644
    > > --- a/fs/xfs/xfs_cap.h
    > > +++ b/fs/xfs/xfs_cap.h
    >
    > ...
    >
    > > -#else
    > > #define xfs_cap_vset(v,p,sz) (-EOPNOTSUPP)
    > > #define xfs_cap_vget(v,p,sz) (-EOPNOTSUPP)
    > > #define xfs_cap_vremove(v) (-EOPNOTSUPP)
    > > #define _CAP_EXISTS (NULL)
    > > -#endif
    > >
    > > #endif /* __KERNEL__ */
    >
    > By the time you do this, probably may as well remove the whole file;
    > the leftover 4 definitions never seem to be used.
    >
    > The same may go for xfs_mac.h.
    >
    > -Eric

    good point. david chinner (dgc) already mentioned that he'd prefer to
    run this through the XFS tree so i'll leave this in his capable hands.

    rday

    --
    ========================================================================
    Robert P. J. Day
    Linux Consulting, Training and Annoying Kernel Pedantry
    Waterloo, Ontario, CANADA

    http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
    ========================================================================
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-29 09:11    [W:5.448 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site