lkml.org 
[lkml]   [2007]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix /sys/device/.../power/state regression
    On Fri, Jan 26, 2007 at 01:56:41PM -0800, David Brownell wrote:

    > I thought the resolution was that fixing a few of those drivers
    > should solve the problem Matthew needed resolved, and that in
    > the meanwhile "rmmod drivername" should suffice. There also seemed
    > to be agreement that power management for wireless devices needed
    > more work; there might need to be a state between "down/off" and
    > "configured and able to talk IP".

    It's certainly the case that fixing those drivers would result in a
    better long-term situation - however, nobody currently seems to have any
    interest in doing so, and I've only got access to a subset of the
    hardware and approximately none of the documentation. It's likely that
    I'll end up spending time on that, but right now I'm afraid that other
    things are taking a higher priority.

    I'm not sure what you mean by using rmmod instead. Most drivers don't
    explicitly set the power state when unbinding, and I can't see anywhere
    in the generic PCI code that will do it.

    As I've said before, I think it's unreasonable to cripple interfaces for
    (mostly) aesthetic reasons without ensuring that equivalent
    functionality already exists. This patch restores useful functionality
    without breaking the extra sanity checks that you've added. I appreciate
    that it's not an interface that you want to support in the long term
    (well, even the short term...), and that suggesting its removal provides
    a useful incentive to fix things properly in the long term. But it would
    be nice if we didn't make it impossible to do this until the right thing
    is implemented.

    --
    Matthew Garrett | mjg59@srcf.ucam.org
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-27 00:19    [W:5.339 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site