Messages in this thread | | | Date | Wed, 24 Jan 2007 11:20:44 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] process include/linux/if_{addr,link}.h with unifdef |
| |
On Tue, Jan 23, 2007 at 10:05:17PM -0800, David Miller wrote: > From: Adrian Bunk <bunk@stusta.de> > Date: Sun, 21 Jan 2007 20:13:19 +0100 > > > After commit d3dcc077bf88806201093f86325ec656e4dbfbce, > > include/linux/if_{addr,link}.h should be processed with unifdef. > > > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > Applied, thanks Adrian. > > I believe at least the 2.6.19 -stable branch will need > this too, right? Please submit to -stable as needed, > and feel free to add my sign-off: > > Signed-off-by: David S. Miller <davem@davemloft.net>
All my patch does is to remove "#ifndef __KERNEL__"'s around userspace #define's from the userspace headers, so it's purely cosmetical.
Except when userspace wrongly defines __KERNEL__, no header-y<->unifdef-y should ever have any non-cosmetical effect.
That said, we really want what I called "cosmetical" - not having "#if{,n}def __KERNEL__" in any userspace headers - it's simply that this is not a serious bug.
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |