Messages in this thread | | | Date | Mon, 22 Jan 2007 13:38:18 +0200 | From | "Alon Bar-Lev" <> | Subject | Re: [patch 03/26] Dynamic kernel command-line - arm |
| |
On 1/18/07, Bodo Eggert <7eggert@gmx.de> wrote: > Alon Bar-Lev <alon.barlev@gmail.com> wrote: > > On 1/18/07, Russell King <rmk+lkml@arm.linux.org.uk> wrote: > >> On Thu, Jan 18, 2007 at 01:58:52PM +0100, Bernhard Walle wrote: > >> > 2. Set command_line as __initdata. > > >> You can't. > >> > >> > -static char command_line[COMMAND_LINE_SIZE]; > >> > +static char __initdata command_line[COMMAND_LINE_SIZE]; > >> > >> Uninitialised data is placed in the BSS. Adding __initdata to BSS > >> data causes grief. > > > There are many places in kernel that uses __initdata for uninitialized > > variables. > > > > For example: > > > static int __initdata is_chipset_set[MAX_HWIFS]; > > > > So all these current places are wrong? > > If I initialize the data will it be OK. > > objdump -t vmlinux |grep -3 is_chipset_set suggests that it's placed > into .init.data here, not into .bss.
Russell ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |