lkml.org 
[lkml]   [2007]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: problems with latest smbfs changes on 2.4.34 and security backports
    Date
    On Mon, 22 Jan 2007 00:03:21 +0100, Willy Tarreau <w@1wt.eu> wrote:

    >Hi Grant !
    >
    >On Mon, Jan 22, 2007 at 09:52:44AM +1100, Grant Coady wrote:
    >> On Fri, 19 Jan 2007 18:05:44 -0700, dann frazier <dannf@dannf.org> wrote:
    >>
    >> >On Thu, Jan 18, 2007 at 06:00:40PM -0700, dann frazier wrote:
    >> >Ah, think I see the problem now:
    >> >
    >> >--- kernel-source-2.4.27.orig/fs/smbfs/proc.c 2007-01-19 17:53:57.247695476 -0700
    >> >+++ kernel-source-2.4.27/fs/smbfs/proc.c 2007-01-19 17:49:07.480161733 -0700
    >> >@@ -1997,7 +1997,7 @@
    >> > fattr->f_mode = (server->mnt->dir_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFDIR;
    >> > else if ( (server->mnt->flags & SMB_MOUNT_FMODE) &&
    >> > !(S_ISDIR(fattr->f_mode)) )
    >> >- fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | S_IFREG;
    >> >+ fattr->f_mode = (server->mnt->file_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) | (fattr->f_mode & S_IFMT);
    >> >
    >> > }
    >> >
    >> client running 2.4.34 with above patch, server is running 2.6.19.2 to
    >> eliminate it from the problem space (hopefully ;) :
    >> grant@sempro:/home/other$ uname -r
    >> 2.4.34b
    >> grant@sempro:/home/other$ ls -l
    >> total 9
    >> drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dir/
    >> drwxr-xr-x 1 grant wheel 4096 2007-01-21 11:44 dirlink/
    >> -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:43 file*
    >> -rwxr-xr-x 1 grant wheel 15 2007-01-21 11:43 filelink*
    >
    >It seems to me that there is a difference, because filelink now appears the
    >same size as file. It's just as if we had hard links instead of symlinks.

    Hi Willy,

    No, those dir and files were created server-side, sorry I gave wrong
    impression, I still get on client side:

    grant@sempro:/home/other$ uname -r
    2.4.34b
    grant@sempro:/home/other$ mkdir test
    grant@sempro:/home/other$ ln -s test testlink
    ln: creating symbolic link `testlink' to `test': Operation not permitted
    grant@sempro:/home/other$ echo "this is also a test" > test/file
    grant@sempro:/home/other$ ln -s test/file test2
    ln: creating symbolic link `test2' to `test/file': Operation not permitted

    trying to create symlinks.

    No problems creating symlinks with 2.4.33.3.

    Grant.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-01-22 01:55    [W:5.368 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site