Messages in this thread | | | Date | Sun, 14 Jan 2007 14:54:11 +0000 | From | Alan <> | Subject | Re: [patch 00/12] Fix ppc64's writing to struct file_operations |
| |
> .read = seq_read, > + .write = lparcfg_write, > .open = lparcfg_open, > .release = single_release, > }; > @@ -581,10 +582,8 @@ int __init lparcfg_init(void) > > /* Allow writing if we have FW_FEATURE_SPLPAR */ > if (firmware_has_feature(FW_FEATURE_SPLPAR) && > - !firmware_has_feature(FW_FEATURE_ISERIES)) { > - lparcfg_fops.write = lparcfg_write; > + !firmware_has_feature(FW_FEATURE_ISERIES)) > mode |= S_IWUSR; > - }
This doesn't appea to do the same thing at all. You need to select between two sets of const inode ops instead, otherwise you turn write on arbitarily. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |