Messages in this thread | | | Date | Wed, 10 Jan 2007 12:27:25 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] libata: PIIX3 support |
| |
Alan wrote: > @@ -786,7 +797,8 @@ > { 2, 3 }, }; > > pci_read_config_word(dev, master_port, &master_data); > - pci_read_config_byte(dev, 0x48, &udma_enable); > + if (ap->udma_mask) > + pci_read_config_byte(dev, 0x48, &udma_enable); > > if (speed >= XFER_UDMA_0) { > unsigned int udma = adev->dma_mode - XFER_UDMA_0;
This creates a situation where the code modifies an uninitialized variable. Ultimately irrelevant, but please init udma_enable to zero so that at least it is valid C code.
Otherwise ACK.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |