Messages in this thread | | | Date | Fri, 8 Sep 2006 09:07:01 +0200 (MEST) | From | Jan Engelhardt <> | Subject | Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven. |
| |
>> +static struct pid_entry proc_base_stuff[] = { >> + NOD(PROC_TGID_INO, "self", S_IFLNK|S_IRWXUGO, >> + &proc_self_inode_operations, NULL, {}), >> + {} >> +}; > >We could save a bunch of bytes here. > >> + /* Lookup the directory entry */ >> + for (p = proc_base_stuff; p->name; p++) { > >By using ARRAY_SIZE here. > >> + for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) { > >like that does.
Also works without the () around ARRAY_SIZE(..)-1
Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |