Messages in this thread | | | Date | Thu, 7 Sep 2006 09:31:11 +0200 | From | Haavard Skinnemoen <> | Subject | Re: [PATCH 05/26] Dynamic kernel command-line - avr32 |
| |
(trimming Cc list)
On Mon, 4 Sep 2006 01:18:04 +0300 Alon Bar-Lev <alon.barlev@gmail.com> wrote:
> > 1. Rename saved_command_line into boot_command_line. > 2. Set command_line as __initdata.
Thanks. Seems to work fine with my setup.
I should probably start using that parse_early_param() stuff, though. I'll update this patch if I do.
Now, do I add a signed-off-by line here, or an acked-by?
Haavard
> Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com> > > --- > > diff -urNp linux-2.6.18-rc5-mm1.org/arch/avr32/kernel/setup.c > linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c --- > linux-2.6.18-rc5-mm1.org/arch/avr32/kernel/setup.c 2006-09-03 > 18:56:48.000000000 +0300 +++ > linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c 2006-09-03 > 20:58:45.000000000 +0300 @@ -44,7 +44,7 @@ struct avr32_cpuinfo > boot_cpu_data = { }; EXPORT_SYMBOL(boot_cpu_data); > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; > > /* > * Should be more than enough, but if you have a _really_ complex > @@ -94,7 +94,7 @@ static unsigned long __initdata fbmem_si > > static void __init parse_cmdline_early(char **cmdline_p) > { > - char *to = command_line, *from = saved_command_line; > + char *to = command_line, *from = boot_command_line; > int len = 0; > char c = ' '; > > @@ -226,7 +226,7 @@ __tagtable(ATAG_MEM, parse_tag_mem); > > static int __init parse_tag_cmdline(struct tag *tag) > { > - strlcpy(saved_command_line, tag->u.cmdline.cmdline, > COMMAND_LINE_SIZE); > + strlcpy(boot_command_line, tag->u.cmdline.cmdline, > COMMAND_LINE_SIZE); return 0; > } > __tagtable(ATAG_CMDLINE, parse_tag_cmdline); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |