Messages in this thread | | | Date | Thu, 7 Sep 2006 08:15:28 -0700 | From | Andrew Morton <> | Subject | Re: 2.6.18-rc5-mm1: strange /proc/interrupts contents on HPC nx6325 |
| |
On Thu, 7 Sep 2006 15:51:05 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> > * Andrew Morton <akpm@osdl.org> wrote: > > > This is due to a gruesome hack (IMO) in the genirq code > > (handle_irq_name()) which magically "knows" about the various types of > > IRQ handler, but doesn't know about the MSI ones. It should be > > converted to a field in irq_desc, or a callback or something. > > a field in irq_desc[] was frowned upon during initial genirq review, due > to size reasons, so i removed it and replaced it with the hack.
irq_desc[] is already in the hundred-byte range. I'm a bit surprised that another char* is worth sweating over.
What's in irq_chip.name, btw? "name for /proc/interrupts". hmm.
> > I already had a whine about this then forgot about it, but it seems that > > code can't be changed by whining at it ;) > > ;) > > i think we could add a 'register handler name' API (or extend > set_irq_handler() API), to pass in the name of handlers, and store it in > a small array (instead of embedding it in irq_desc)? handle_irq_name() > is not performance-critical.
spose so. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |