lkml.org 
[lkml]   [2006]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.18 perfmon new code base + libpfm + pfmon
Andrew,

On Wed, Sep 27, 2006 at 04:31:00PM -0700, Andrew Morton wrote:
> >
> > Here is the summary of the various point raised by your review and the current
> > status. I am hoping to close all points by next release.
> >
> > ...
> >
> > [akpm]: use fget_light() in some place instead of fget()
> > - not sure understand when to use one versus the other
> >
>
> They are always interchangeable. fget_light() is simply an optimised,
> messier-to-use version.

What are exactly the assumptions of fget_light()?

>
> >
> > ..
> >
> > [akpm]: carta_random32() should be in another header file
> > - yes, I know. Should I create a specific header file? I don't think random.h
> > is meant for this.
>
> I suppose so. Or just stick the declaration into kernel.h.
>
> I had a patch go past the other day which had a hand-rolled
> fast-but-not-very-good pseudo random number generator in it. I couldn't
> remember where I'd seen one, and now I can't remember what patch it was
> that needed it. Sigh.
>
> Anyway, a standalone patch which adds that function into lib/whatever.c
> would be nice.

I will post a standalone patch for carta random. I can provide a standalone header
file in include/linux/carta_random.h.

--
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-28 08:53    [W:0.121 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site