lkml.org 
[lkml]   [2006]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] libata: _GTF support
Kristen Carlson Accardi wrote:
> _GTF is an acpi method that is used to reinitialize the drive. It returns
> a task file containing ata commands that are sent back to the drive to restore
> it to boot up defaults.
>
> Signed-off-by: Kristen Carlson Accardi <kristen.c.accardi@intel.com>

I have minor complaints only...


> +EXPORT_SYMBOL_GPL(do_drive_get_GTF);
> +EXPORT_SYMBOL_GPL(do_drive_set_taskfiles);
> +EXPORT_SYMBOL_GPL(ata_acpi_exec_tfs);
> +
> --- 2.6-mm.orig/drivers/ata/libata-core.c
> +++ 2.6-mm/drivers/ata/libata-core.c
> @@ -90,6 +90,10 @@ static int ata_probe_timeout = ATA_TMOUT
> module_param(ata_probe_timeout, int, 0444);
> MODULE_PARM_DESC(ata_probe_timeout, "Set ATA probing timeout (seconds)");
>
> +int noacpi;
> +module_param(noacpi, int, 0444);
> +MODULE_PARM_DESC(noacpi, "Disables the use of ACPI in suspend/resume when set");
> +
> MODULE_AUTHOR("Jeff Garzik");
> MODULE_DESCRIPTION("Library module for ATA devices");
> MODULE_LICENSE("GPL");
> @@ -1597,6 +1601,9 @@ int ata_bus_probe(struct ata_port *ap)
> /* reset and determine device classes */
> ap->ops->phy_reset(ap);
>
> + /* retrieve and execute the ATA task file of _GTF */
> + ata_acpi_exec_tfs(ap);
> +
> for (i = 0; i < ATA_MAX_DEVICES; i++) {
> dev = &ap->device[i];
>
> --- 2.6-mm.orig/drivers/ata/libata.h
> +++ 2.6-mm/drivers/ata/libata.h
> @@ -43,6 +43,7 @@ extern struct workqueue_struct *ata_aux_
> extern int atapi_enabled;
> extern int atapi_dmadir;
> extern int libata_fua;
> +extern int noacpi;
> extern struct ata_queued_cmd *ata_qc_new_init(struct ata_device *dev);
> extern int ata_rwcmd_protocol(struct ata_queued_cmd *qc);
> extern void ata_dev_disable(struct ata_device *dev);
> @@ -74,6 +75,33 @@ extern void ata_port_init(struct ata_por
> extern struct ata_probe_ent *ata_probe_ent_alloc(struct device *dev,
> const struct ata_port_info *port);
>
> +/* libata-acpi.c */
> +#ifdef CONFIG_SATA_ACPI
> +extern int do_drive_get_GTF(struct ata_port *ap, int ix,
> + unsigned int *gtf_length, unsigned long *gtf_address,
> + unsigned long *obj_loc);
> +extern int do_drive_set_taskfiles(struct ata_port *ap,
> + struct ata_device *atadev, unsigned int gtf_length,
> + unsigned long gtf_address);
> +extern int ata_acpi_exec_tfs(struct ata_port *ap);
> +#else
> +static inline int do_drive_get_GTF(struct ata_port *ap, int ix,
> + unsigned int *gtf_length, unsigned long *gtf_address,
> + unsigned long *obj_loc)
> +{
> + return 0;
> +}
> +static inline int do_drive_set_taskfiles(struct ata_port *ap,
> + struct ata_device *atadev,
> + unsigned int gtf_length, unsigned long gtf_address)
> +{
> + return 0;
> +}
> +static inline int ata_acpi_exec_tfs(struct ata_port *ap)
> +{
> + return 0;
> +}
> +#endif

1) No symbols should be exported to external kernel modules. Delete
all EXPORT_SYMBOL_GPL()

2) No symbols except for ata_acpi_exec_tfs() should be exported outside
of the libata-acpi.c C module. Mark everything except
ata_acpi_exec_tfs() static, and remove the 'static inline' no-op
functions for everything but ata_acpi_exec_tfs().

Otherwise ACK.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-28 00:53    [W:0.066 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site