Messages in this thread | | | Date | Tue, 26 Sep 2006 13:23:34 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: [PATCH 41/47] drivers/base: check errors |
| |
On 9/26/06, Greg KH <greg@kroah.com> wrote: > From: Andrew Morton <akpm@osdl.org> > > Add lots of return-value checking. > > + if (error) > + goto out; > + error = sysfs_create_link(&bus->devices.kobj, > + &dev->kobj, dev->bus_id); > + if (error) > + goto out; > + error = sysfs_create_link(&dev->kobj, > + &dev->bus->subsys.kset.kobj, "subsystem"); > + if (error) > + goto out; > + error = sysfs_create_link(&dev->kobj, > + &dev->bus->subsys.kset.kobj, "bus"); > } > +out: > return error;
What about removing the links that were created if one of these calls fails?
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |