Messages in this thread | | | Date | Sat, 23 Sep 2006 22:29:12 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] missing includes from infiniband merge |
| |
On Sat, Sep 23, 2006 at 04:44:16PM +0100, Al Viro wrote: > indirect chains of includes are arch-specific and can't > be relied upon... (hell, even attempt to build it for > itanic would trigger vmalloc.h ones; err.h triggers > on e.g. alpha). > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > --- > drivers/infiniband/core/mad_priv.h | 1 + > drivers/infiniband/hw/amso1100/c2_provider.c | 1 + > drivers/infiniband/hw/amso1100/c2_rnic.c | 1 + > drivers/infiniband/hw/ipath/ipath_diag.c | 1 + > 4 files changed, 4 insertions(+), 0 deletions(-) A better fix would be to avoid the arch dependency in the non-arch .h files so that in most cases it just works??
That will result in a few files being included twice or more but does that matter with current gcc - I doubt.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |