Messages in this thread | | | From | Oleg Verych <> | Subject | Re: [PATCH 2/4] Blackfin: Serial driver for Blackfin arch on 2.6.18 | Date | Fri, 22 Sep 2006 04:03:17 +0200 |
| |
Hallo, Luke Yang, who wrote: > +static void bfin_serial_mctrl_check(struct bfin_serial_port *uart); > + > +/* > + * interrupts disabled on entry > + */
spelling error: _are_ disabled please grep && sed all patches
> +static void bfin_serial_stop_tx(struct uart_port *port) > +{ > + struct bfin_serial_port *uart = (struct bfin_serial_port *)port; > + unsigned short ier; > + ier = UART_GET_IER(uart); > + ier &= ~ETBEI; > + UART_PUT_IER(uart, ier); > +#ifdef CONFIG_SERIAL_BFIN_DMA > + disable_dma(uart->tx_dma_channel); > +#endif > +}
one blank line after local variables; you are using this in some functions, in some you are not...
> + > +static void bfin_serial_shutdown(struct uart_port *port) > +{ > + struct bfin_serial_port *uart = (struct bfin_serial_port *)port; > +
yes, one more space will be nicer
> + free_irq(uart->port.irq+1, uart);
here and the like
-- -o--=O`C #oo'L O 5 years ago TT and WTC7 were assassinated <___=E M learn more how (tm) <http://911research.com>
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |