Messages in this thread Patch in this message | | | Date | Fri, 22 Sep 2006 11:03:16 +1000 | From | David Chinner <> | Subject | Re: [PATCH -mm] rescue large xfs preferred iosize from the inode diet patch |
| |
On Thu, Sep 21, 2006 at 05:33:24PM -0500, Eric Sandeen wrote: > The inode diet patch in -mm unhooked xfs_preferred_iosize from the stat call: .... > Signed-off-by: Eric Sandeen <sandeen@sandeen.net> > > XFS guys, does this look ok? > > Index: linux-2.6.18/fs/xfs/linux-2.6/xfs_iops.c > =================================================================== > --- linux-2.6.18.orig/fs/xfs/linux-2.6/xfs_iops.c > +++ linux-2.6.18/fs/xfs/linux-2.6/xfs_iops.c > @@ -623,12 +623,16 @@ xfs_vn_getattr( > { > struct inode *inode = dentry->d_inode; > bhv_vnode_t *vp = vn_from_inode(inode); > + xfs_inode_t *ip; > int error = 0; > > if (unlikely(vp->v_flag & VMODIFIED)) > error = vn_revalidate(vp); > - if (!error) > + if (!error) { > generic_fillattr(inode, stat); > + ip = xfs_vtoi(vp); > + stat->blksize = xfs_preferred_iosize(ip->i_mount); > + } > return -error; > }
ACK. Looks good, Eric. Good catch.
Cheers,
Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |