Messages in this thread | | | Subject | Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6 | From | Florian Weimer <> | Date | Thu, 21 Sep 2006 15:29:09 +0200 |
| |
* Arjan van de Ven:
>> if (irq) >> spin_lock(&np->tx_lock); >> else >> spin_lock_irqsave(&np->tx_lock, flag); > > double eeeep > > this is wrong to do with in_interrupt() as gating factor!
Well, this is not Hayim fault. It's in 2.6.18 as is.
Unfortunately, the driver does not work very well. Transmitting frames hangs after a while (quickly to reproduce with ping -f -s40000). Any suggestions how we could this get working? The cards used work quite well in older systems despite all the driver bugs, but current systems with different timings expose them.
-- Florian Weimer <fweimer@bfk.de> BFK edv-consulting GmbH http://www.bfk.de/ Durlacher Allee 47 tel: +49-721-96201-1 D-76131 Karlsruhe fax: +49-721-96201-99 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |