Messages in this thread | | | Date | Wed, 20 Sep 2006 13:54:57 -0700 | From | "Dmitriy Zavin" <> | Subject | Re: [PATCH 1/4] x86_64/i386 thermal mce: Refactor thermal throttle reporting. |
| |
Ok, will move the mce_log part into mce.c in x86_64 and go back to returning 0/1 from therm_throt_process. Then only the x86_64 thermal mce will mcelog, and no #ifdefs :)
On 9/20/06, Andi Kleen <ak@suse.de> wrote: > > > + > > +#include <linux/percpu.h> > > +#include <linux/cpu.h> > > +#include <asm/cpu.h> > > +#include <linux/notifier.h> > > +#include <asm/therm_throt.h> > > + > > +#ifdef CONFIG_X86_64 > > > Sorry, no such ifdefs allowed. That is what I meant with making the merged code > worse than split code. > > -Andi > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |