Messages in this thread | | | Date | Sat, 2 Sep 2006 09:48:18 -0700 | From | Andrew Morton <> | Subject | Re: Support for TI FlashMedia (pci id 104c:8033, 104c:803b) flash card readers |
| |
On Sat, 02 Sep 2006 13:15:52 +0200 Pierre Ossman <drzeus-list@drzeus.cx> wrote:
> Andrew, the stuff meant for you is at the bottom.
<panics>
> Alex Dubov wrote: > > Hi there. > > I've made a couple of fixes to my flashmedia driver > > (http://developer.berlios.de/projects/tifmxx/) to the > > effect of much improved R/W speed in PIO mode and > > writing speed in DMA mode. > > > > The users will be pleased :) > > > I also tried to clean-up reverse engineering mess out > > of the code - it should be more readable now. > > > > Wonderful. Things are looking a lot better. I have a few questions though. > > The constants you've borrowed from OMAP, have you confirmed all of them? > If not, you should add a comment to those that are pure speculation so far. > > tifm_sd_op_flags() still use literals. Could you fix up some defines > there as well? > > tifm_sd_fetch_resp() could be redone as a for loop to make it more > obvious what's going on. Also, please don't put several statements on > one line. > > You should probably rename tifm_sd_set_data_to(). It isn't obvious that > 'to' stands for 'timeout'. Same thing with other instances of 'to'. > > We're also in the process of fixing this dreadfully slow write mess. > What I'd like to see from you is to double check that bytes_xfered is > set to the number of bytes successfully sent to the _card_, not the > controller. This is critical for correct handling of bus errors. > > > Next on my list is MemoryStick functionality. > > > > > > I would suggest finishing this and getting it merged to be your top > priority. There are quite a few people who would like to have this > hardware supported. Which brings me to... > > Andrew, we could use some help with how this driver should fit into the > kernel tree. The hardware is multi-function, so there will be a couple > of drivers, one for every function, and a common part. How has this been > organised in the past? >
Greg would be a far better person that I for this. Is it a PCI device?
-- VGER BF report: H 0 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |