Messages in this thread | | | Date | Thu, 14 Sep 2006 15:46:21 -0700 | From | Martin Bligh <> | Subject | Re: [PATCH 0/11] LTTng-core (basic tracing infrastructure) 0.5.108 |
| |
> i disagree. Consider the following example from LTT: ... > trace_socket_sendmsg(sock, sock->sk->sk_family, > sock->sk->sk_type, > sock->sk->sk_protocol, > size); ...
> what do the 5 extra lines introduced by trace_socket_sendmsg() tell us? > Nothing. They mostly just duplicate the information i already have from > the function declaration. They obscure the clear view of the function: ... > the resulting visual and structural redundancy hurts.
Couldn't that be easily fixed by just doing
trace_socket_sendmsg(sock, size);
and have it work out which esoteric parts of the sock we want to trace, and which we don't? Is much less visually invasive, and gives the same effect.
M.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |