Messages in this thread | | | Date | Wed, 13 Sep 2006 11:30:32 +0300 | From | "Alon Bar-Lev" <> | Subject | Re: [PATCH 05/26] Dynamic kernel command-line - avr32 |
| |
Thanks! Can you please sign-off the patch?
On 9/13/06, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote: > On Thu, 7 Sep 2006 19:21:17 +0300 > "Alon Bar-Lev" <alon.barlev@gmail.com> wrote: > > > On 9/7/06, Haavard Skinnemoen <hskinnemoen@atmel.com> wrote: > > > > > On Mon, 4 Sep 2006 01:18:04 +0300 > > > Alon Bar-Lev <alon.barlev@gmail.com> wrote: > > > > > > > > > > > 1. Rename saved_command_line into boot_command_line. > > > > 2. Set command_line as __initdata. > > > > > > I should probably start using that parse_early_param() stuff, > > > though. I'll update this patch if I do. > > The patch "AVR32: Use parse_early_param" does that. Here's an updated > version of your patch that goes on top of that one. > > --- > arch/avr32/kernel/setup.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > Index: linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c > =================================================================== > --- linux-2.6.18-rc5-mm1.orig/arch/avr32/kernel/setup.c 2006-09-07 10:05:07.000000000 +0200 > +++ linux-2.6.18-rc5-mm1/arch/avr32/kernel/setup.c 2006-09-07 10:30:00.000000000 +0200 > @@ -44,7 +44,7 @@ struct avr32_cpuinfo boot_cpu_data = { > }; > EXPORT_SYMBOL(boot_cpu_data); > > -static char command_line[COMMAND_LINE_SIZE]; > +static char __initdata command_line[COMMAND_LINE_SIZE]; > > /* > * Should be more than enough, but if you have a _really_ complex > @@ -202,7 +202,7 @@ __tagtable(ATAG_MEM, parse_tag_mem); > > static int __init parse_tag_cmdline(struct tag *tag) > { > - strlcpy(saved_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE); > + strlcpy(boot_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE); > return 0; > } > __tagtable(ATAG_CMDLINE, parse_tag_cmdline); > @@ -317,7 +317,7 @@ void __init setup_arch (char **cmdline_p > init_mm.end_data = (unsigned long) &_edata; > init_mm.brk = (unsigned long) &_end; > > - strlcpy(command_line, saved_command_line, COMMAND_LINE_SIZE); > + strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE); > *cmdline_p = command_line; > parse_early_param(); > > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |