lkml.org 
[lkml]   [2006]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] force_quiescent_state: factor out duplicated code
On Sun, Sep 10, 2006 at 08:18:10PM +0400, Oleg Nesterov wrote:
> On top of rcu-simplify-improve-batch-tuning.patch
>
> Cleanup. Move '#ifdef CONFIG_SMP' check and rdp->bhlimit setting
> into force_quiescent_state().


Pushing the rdp->blimit setting into force_quiescent_state is fine,
but I see no need to insert #ifdef CONFIG_SMP into a routine.
Let us continue to have separate versions of force_quiescent_state()
for CONFIG_SMP and !CONFIG_SMP. It looks cleaner with #ifdefs inserted
in between.

Thanks
Dipankar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-10 23:07    [W:0.101 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site