Messages in this thread | | | Date | Thu, 31 Aug 2006 22:46:43 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH -mm] fs/bio.c: tweaks |
| |
On Thu, 31 Aug 2006 23:20:23 +0200 Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
> Calculate a variable in bvec_alloc_bs() only once needed, not earlier > (bio.o down from 18408 to 18376 Bytes, 32 Bytes saved, probably due to > data locality improvements).
OK, I spose.
> Init variable idx to silence a gcc warning which already existed in the > unmodified original base file (bvec_alloc_bs() handles idx > correctly, so there's no need for the warning): > fs/bio.c: In function `bio_alloc_bioset': > fs/bio.c:169: warning: `idx' may be used uninitialized in this function
I'm heartily sick of that one too.
> Inline bio_set_map_data() since it's only called once.
Is OK, gcc will take care of that.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |