Messages in this thread | | | Subject | Re: [Patch] Uninitialized variable in drivers/scsi/ncr53c8xx.c | From | Eric Sesterhenn <> | Date | Fri, 01 Sep 2006 17:45:56 +0200 |
| |
On Thu, 2006-08-31 at 23:00 -0700, Andrew Morton wrote: > On Fri, 01 Sep 2006 01:29:12 +0200 > Eric Sesterhenn <snakebyte@gmx.de> wrote: > > > hi, > > > > this was spotted by coverity (id #880). > > We use simple_strtoul() earlier to initialize pe, > > if the function fails, it also does not initialize it. > > Therefore we should initialize it ourselves, so the check > > in the OPT_TAGS case "if (pe && *pe == '/')" makes sense, and > > actually makes the command line parsing more robust. > > > > Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> > > simple_strtoul() always initialises `pe'.
D'oh. But i think we should apply the patch nevertheless, to make the parsing code more robust, in case the command line is screwed up (and simple_strtoul() is never called).
Eric
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |