Messages in this thread | | | Subject | Re: [patch 4/9] Guest page hinting: volatile swap cache. | From | Dave Hansen <> | Date | Fri, 01 Sep 2006 08:04:06 -0700 |
| |
On Fri, 2006-09-01 at 13:10 +0200, Martin Schwidefsky wrote: > +#if defined(CONFIG_PAGE_STATES) > + > +struct page * find_get_page_nodiscard(struct address_space *mapping, > + unsigned long offset) > +{ > + struct page *page; > + > + read_lock_irq(&mapping->tree_lock); > + page = radix_tree_lookup(&mapping->page_tree, offset); > + if (page) > + page_cache_get(page); > + read_unlock_irq(&mapping->tree_lock); > + return page; > +} > + > +EXPORT_SYMBOL(find_get_page_nodiscard); > + > +#endif
Is it worth having another full copy of find_get_page()? What about a "nodiscard" argument?
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |