Messages in this thread | | | Subject | Re: How to lock current->signal->tty | From | Jes Sorensen <> | Date | 09 Aug 2006 04:09:37 -0400 |
| |
>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
Alan> Ar Maw, 2006-08-08 am 09:41 -0700, ysgrifennodd Luck, Tony: >> unaligned accesses at all is rather controversial. So its a 50-50 >> shot whether I'll fix it by adding the mutex_lock/mutex_unlock >> around the use of current->signal->tty, or just rip this out and >> just leave the printk().
Alan> Personally I'd just rip it out full stop. Its trivial to use Alan> kprobes and friends to audit such things if there is a Alan> performance concern.
Personally I don't like the current approach. However, I believe the philosophy behind it is that users rarely look in dmesg and they should be notified (and beaten with a stick) when their badly written app spawns unaligned accesses which end up being emulated by the kernel.
These messages are normally caused by userland code, so kprobes probably wont do much good :)
Cheers, Jes - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |