lkml.org 
[lkml]   [2006]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC/PATCH] revoke/frevoke system calls V2
    Pekka Enberg wrote:
    >
    > I'll put them on my todo and in the meanwhile, you can find the latest
    > patches here:
    > http://www.kernel.org/pub/linux/kernel/people/penberg/patches/revoke/
    >
    > Thanks for taking the time to review the patch!

    + retry:
    + if (signal_pending(current)) {
    + err = -ERESTARTSYS;
    + goto out;
    + }
    +
    + to_close = alloc_revoke_table(inode, to_exclude, &max_fds);
    + if (!to_close) {
    + err = -ENOMEM;
    + goto out;
    + }
    +
    + read_lock(&tasklist_lock);
    +
    + /*
    + * If someone forked while we were allocating memory, try again.
    + */
    + if (inode_fds(inode, to_exclude) > max_fds) {
    + read_unlock(&tasklist_lock);
    + goto retry;
    + }

    It seems, the retry is leaking the to_close table.

    Ciao, ET.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-09 22:11    [W:6.398 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site