Messages in this thread | | | Date | Mon, 7 Aug 2006 20:39:14 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports |
| |
On Tue, 08 Aug 2006 13:25:34 +1000 Greg Banks <gnb@melbourne.sgi.com> wrote:
> cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export > node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out. > > Signed-off-by: Greg Banks <gnb@melbourne.sgi.com> > --- > > arch/i386/kernel/smpboot.c | 2 +- > 1 files changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c > =================================================================== > --- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c > +++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c > @@ -609,7 +609,7 @@ extern struct { > /* which logical CPUs are on which nodes */ > cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly = > { [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE }; > -EXPORT_SYMBOL(node_2_cpu_mask); > +EXPORT_SYMBOL_GPL(node_2_cpu_mask); > /* which node each logical CPU is on */ > int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 }; > EXPORT_SYMBOL(cpu_2_node);
All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be inclined to make any new exports match that.
<edits the diffs>
OK? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |