Messages in this thread | | | Date | Mon, 7 Aug 2006 13:24:18 -0700 | From | Andrew Morton <> | Subject | Re: [-mm patch] add timespec_to_us() and use it in kernel/tsacct.c |
| |
On Mon, 7 Aug 2006 15:32:41 +0200 Adrian Bunk <bunk@stusta.de> wrote:
> On Sun, Aug 06, 2006 at 10:21:29PM -0700, Andrew Morton wrote: > > On Sun, 6 Aug 2006 23:30:19 -0400 > > Matt Reuther <mreuther@umich.edu> wrote: > > > > > I got an Error while compiling 2.6.18-rc3-mm2: > > > > > > AR arch/i386/lib/lib.a > > > GEN .version > > > CHK include/linux/compile.h > > > UPD include/linux/compile.h > > > CC init/version.o > > > LD init/built-in.o > > > LD .tmp_vmlinux1 > > > kernel/built-in.o(.text+0x45667): In function `bacct_add_tsk': > > > include/linux/time.h:130: undefined reference to `__divdi3' > > > make: *** [.tmp_vmlinux1] Error 1 > > > > > > I attached the .config file. > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/hot-fixes/csa-basic-accounting-over-taskstats-fix.patch > > should fix this, thanks. > > This doesn't look correct since do_div() does not guarantee to return > more than 32bit.
eh? We use do_div() to do 64bit/something all the time??
> What about the patch below that adds a timespec_to_us() to time.h and > uses this function in kernel/tsacct.c?
Seems reasonable, but it'd be better as two patches..
Do we do timespec->microseconds anywhere else? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |