lkml.org 
[lkml]   [2006]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/10] -mm clocksource: add some new API calls
From
Date
On Fri, 2006-08-04 at 12:28 -0700, Daniel Walker wrote:
> > > int clocksource_register(struct clocksource *c)
> > > {
> > > int ret = 0;
> > > unsigned long flags;
> > >
> > > + if (unlikely(!c))
> > > + return -EINVAL;
> > > +
> >
> > I'm not sure I understand the need for this. Is it really likely someone
> > would pass NULL to clocksource_register()?
>
> Not likely, I was just covering all possibilities.. It might be better
> as a BUG_ON() actually.

BUG_ON is the only thing, which can be correct here. Registering a NULL
clocksource simply is a bug, but even the BUG_ON is overkill here.

tglx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-04 23:07    [W:0.088 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site