Messages in this thread | | | Subject | Re: [PATCH 04/10] -mm clocksource: add some new API calls | From | Thomas Gleixner <> | Date | Fri, 04 Aug 2006 23:05:02 +0200 |
| |
On Fri, 2006-08-04 at 12:28 -0700, Daniel Walker wrote: > > > int clocksource_register(struct clocksource *c) > > > { > > > int ret = 0; > > > unsigned long flags; > > > > > > + if (unlikely(!c)) > > > + return -EINVAL; > > > + > > > > I'm not sure I understand the need for this. Is it really likely someone > > would pass NULL to clocksource_register()? > > Not likely, I was just covering all possibilities.. It might be better > as a BUG_ON() actually.
BUG_ON is the only thing, which can be correct here. Registering a NULL clocksource simply is a bug, but even the BUG_ON is overkill here.
tglx
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |