lkml.org 
[lkml]   [2006]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] loop.c: kernel_thread() retval check - 2.6.17.9
    On Mon, 28 Aug 2006 07:55:56 +0400
    Solar Designer <solar@openwall.com> wrote:

    > On Thu, Aug 24, 2006 at 03:41:00AM -0300, Julio Auto wrote:
    > > this is my porting (to 2.6.x) of the loop.c issue reported and patched
    > > by Solar Designer, to whom all credits of the original idea to the
    > > patch go (more info in the original "[PATCH] loop.c: kernel_thread()
    > > retval check" e-mail thread).
    >
    > The patch looks good to me, although I did not test it.
    >
    > > Honestly, I couldn't test it on other computers, but mine. But the
    > > tests were made against a stock (unmodified) 2.6.17.9 kernel and the
    > > patch works like it should. Nevertheless, a second thought/review is
    > > always appreciated.
    >
    > I think that testing this on a single machine is fine, but it is
    > preferable that you also check for any resource leaks. That is, replace
    > the kernel_thread() call with -EAGAIN, then run losetup in a loop and
    > see whether the system possibly leaks a resource. I did apply this sort
    > of testing to my original 2.4 patch.
    >
    > > Signed-off-by: Julio Auto <mindvortex@gmail.com>
    >
    > Acked-by: Solar Designer <solar@openwall.com>
    >
    > > --- drivers/block/loop.c.orig 2006-08-23 11:44:51.000000000 -0700
    > > +++ drivers/block/loop.c 2006-08-24 00:33:54.000000000 -0700
    > > @@ -841,10 +841,20 @@ static int loop_set_fd(struct loop_devic
    > >
    > > error = kernel_thread(loop_thread, lo, CLONE_KERNEL);
    > > if (error < 0)
    > > - goto out_putf;
    > > + goto out_clr;
    > > wait_for_completion(&lo->lo_done);
    > > return 0;
    > >
    > > + out_clr:
    > > + lo->lo_device = NULL;
    > > + lo->lo_flags = 0;
    > > + lo->lo_backing_file = NULL;
    > > + set_capacity(disks[lo->lo_number], 0);
    > > + invalidate_bdev(bdev, 0);
    > > + bd_set_size(bdev, 0);
    > > + mapping_set_gfp_mask(mapping, lo->old_gfp_mask);
    > > + lo->lo_state = Lo_unbound;
    > > +
    > > out_putf:
    > > fput(file);
    > > out:
    >

    The plan is to stop using the deprecated kernel_thread() in loop altogether.

    Please review

    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc4/2.6.18-rc4-mm3/broken-out/kthread-convert-loopc-to-kthread.patch

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-28 06:45    [W:8.224 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site