lkml.org 
[lkml]   [2006]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH](memory hotplug) Repost remove useless message at boot time from 2.6.18-rc4.
    Am Fr 25.08.2006 13:59 schrieb Yasunori Goto <y-goto@jp.fujitsu.com>:
    >
    >>
    >> > I sent a patch a while ago that gets rid of the whole namespace
    >> > walking
    >> > by making acpi_memoryhotplug an acpi device and making use of the
    >> > .add
    >> > callback function and the acpi_bus_register_driver call.
    >> >
    >> > I am not sure whether this is possible if you have multiple memory
    >> > devices, though (if not maybe it should be made possible?)...
    >> >
    >> > Yasunori even tested the patch and sent an Ok:
    >> > http://marc.theaimsgroup.com/?t=114065312400001&r=1&w=2
    >> >
    >> > If this is acceptable I can rebase the patch on a current kernel.
    >>
    >> Hi. Thomas-san.
    >> Did you rebase your patch?
    >>
    >> I'm trying to do it now too.
    >> But, current code (2.6.18-rc4) seems to register handler for
    >> only enable status devices at boot time.
    >> So, notification is -discarded- due to no handler for new memory
    >> device when hot-add event occurs. Hmmm. :-(
    >No, what I see the notify handler is always installed.
    >But there seem to be added some device state code, which I think is not
    >correct:
    >E.g. the state in acpi_memory_device_add():
    >    mem_device->state = MEMORY_POWER_ON_STATE;
    >should be evaluated from _STA function.
    > When an ACPI memory device is added, the physical memory might not
    >be added yet... IMO only one state, the one evaluated from _STA should
    >be used.
    >I'll have a closer look.
    >
    >This probably is nothing for 2.6.18 ... you never know..., but maybe it
    >can be added
    >to ACPI test branch or mm?
    >Patch is against 2.6.18-rc4 and only compile
    >tested (don't have hardware to test).
    >
    >The attached patch moves the install/remove notify handler to the
    >.add/.remove callback functions that get invoked for every ACPI memory
    >device
    >(like it is done in other ACPI modules).
    >No need for an additional walk_namespace() call.
    >
    >Sorry, I can only attach patch because of webmailer...
    >

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-08-27 14:53    [W:4.468 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site