lkml.org 
[lkml]   [2006]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [take12 3/3] kevent: Timer notifications.
From
Date
On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote:
> ]> > + lockdep_set_class(&t->ktimer_storage.lock, &kevent_timer_key);
> >
> > When looking at the kevent_storage_init callers most need to do
> > those lockdep_set_class class. Shouldn't kevent_storage_init just
> > get a "struct lock_class_key *" argument?
>
> It will not work, since inode is used for both socket and inode
> notifications (to save some space in struct sock), lockdep initalization
> is performed on the highest level, so I put it alone.

Call me a cynic, but I'm always a bit sceptical about needing lockdep
annotations like this... Can you explain why you need it in this case,
including the proof that it's safe?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-08-21 13:31    [W:0.728 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site