Messages in this thread | | | Date | Mon, 21 Aug 2006 17:01:10 -0700 | Subject | Re: [PATCH 1/3] futex_find_get_task: remove an obscure EXIT_ZOMBIE check | From | Bill Huey (hui) <> |
| |
On Mon, Aug 21, 2006 at 09:06:04PM +0400, Oleg Nesterov wrote: > (Compile tested). > > futex_find_get_task: > > if (p->state == EXIT_ZOMBIE || p->exit_state == EXIT_ZOMBIE) > return NULL; > > I can't understand this. First, p->state can't be EXIT_ZOMBIE. The ->exit_state > check looks strange too. Sub-threads or tasks whose ->parent ignores SIGCHLD go > directly to EXIT_DEAD state (I am ignoring a ptrace case). Why EXIT_DEAD tasks > should be ok? Yes, EXIT_ZOMBIE is more important (a task may stay zombie for a > long time), but this doesn't mean we should explicitely ignore other EXIT_XXX > states.
The p->state variable for EXIT_ZOMBIE is only live for some mystery architecture in arch/xtensa/kernel/ptrace.c
It could be a typo under architecture so maybe it's better fixed there as well with a "state" to "exit_state" change. I don't really know for sure since I don't work under that architecure.
bill
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |